Skip to content

test(jump2d): react to Nightly improving stuffed keys handling - #2543

Merged
echasnovski merged 1 commit into
nvim-mini:mainfrom
abeldekat:fix_test_jump2d
Aug 30, 2026
Merged

test(jump2d): react to Nightly improving stuffed keys handling#2543
echasnovski merged 1 commit into
nvim-mini:mainfrom
abeldekat:fix_test_jump2d

Conversation

@abeldekat

Copy link
Copy Markdown
Member

Details:

  • See PR 41529 in neovim/neovim

Test T['start()']['works in Operator-pending mode'] failed. I think it is a timing problem. When I manually follow the test steps everything seems right.
Not sure if adding sleep is the best solution.

@abeldekat

Copy link
Copy Markdown
Member Author

Not sure if adding sleep is the best solution.

Perhaps it's best to regenerate screenshot tests/screenshots/tests-test_jump2d.lua---start()---works-in-Operator-pending-mode-003

The "dot" on line 5 is similar to the "d" on line 5 in tests/screenshots/tests-test_jump2d.lua---start()---works-in-Operator-pending-mode

@echasnovski

Copy link
Copy Markdown
Member

Not sure if adding sleep is the best solution.

Perhaps it's best to regenerate screenshot tests/screenshots/tests-test_jump2d.lua---start()---works-in-Operator-pending-mode-003

The "dot" on line 5 is similar to the "d" on line 5 in tests/screenshots/tests-test_jump2d.lua---start()---works-in-Operator-pending-mode

Yeah, this does look like some issue with redraw. Which I think is some kind of regression of the linked PR, but not sure if it is consequential enough to create a contained repro and make an issue.

As the core tested stuff is showing the labels after the dot, I think it is safe to ignore non-buffer lines here. There are two approaches here:

  • Add a child.cmd('mode') to clear and redraw before problematic screenshot(s). It can also be used instead of child.cmd('redrawstatus') earlier.
  • Explicitly ignore text and attributes of non-buffer lines. In this case lines 4 and 5.

Both are fine with me. Let's go with whichever you prefer.

Details:
- See PR 41529 in neovim/neovim
@abeldekat

Copy link
Copy Markdown
Member Author

Both are fine with me. Let's go with whichever you prefer.

Thanks! I opted to explicitly ignore.

@echasnovski echasnovski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@echasnovski
echasnovski merged commit a311ed2 into nvim-mini:main Aug 30, 2026
12 checks passed
@abeldekat
abeldekat deleted the fix_test_jump2d branch August 30, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants