test(network): ack NATS messages before signalling test completion (backport) - #4489
Merged
Conversation
TestNetwork_Reprocess called wg.Done() before msg.Ack(). Once Done released the test, its cleanup shut down the embedded NATS server, and the ack on the callback goroutine failed with "nats: connection closed" on slow CI runners. Also stop calling require inside NATS callback goroutines (FailNow must run on the test goroutine) and read the ack error in the events integration test under the mutex instead of through a shared variable. Assisted-by: AI (cherry picked from commit 17fcac4)
stevenvegt
requested review from
gerardsn,
reinkrul and
woutslakhorst
as code owners
September 9, 2026 06:56
Contributor
|
Coverage Impact This PR will not change total coverage. 🚦 See full report on Qlty Cloud »🛟 Help
|
reinkrul
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #4488 to V6.2. See that PR for the analysis. Cherry-picked without conflicts; verified with go test -race on the affected packages.