feat: import path-router from services monorepo - #1
Merged
Merged
Conversation
added 7 commits
July 8, 2026 12:28
Brings in the path-router service (istio Gateway API HTTPRoute routing, container-scope-override blue/green sync) from nullplatform/services, flattened to the repo root, along with the standard CI workflow set.
…mple The base_domain enum leaked a real testing domain (path-router.api-private.playground.nullapps.io). Replace it and the matching README examples with a generic example.com placeholder.
.gitignore (Node.js-specific), Dockerfile (http-echo placeholder), and ci.yml (docker build/push) came from the generic "Any Technology" template and aren't used by this shell-script/tofu-based service.
Covers the runtime output/ directory written by scripts/istio/build_context, plus common IDE folders (.idea, .vscode, .claude) and OS cruft (.DS_Store).
… nullplatform Mirrors the specs/install convention added for rds-postgres-server/db: a working, copy-pasteable OpenTofu example that registers the service specification, the service-level agent association, and the container-scope-override hook on the target scope specification via nullplatform/tofu-modules. Unlike RDS, path-router has no requirements/ step since it provisions no cloud infrastructure.
Removing it broke the live service_specification registered against PAE's account (which reads this file directly to render the spec) — the enum is the actual runtime source of truth, not just documentation. Keep the generic placeholder alongside the real domain instead of replacing it.
Registering the service specification isn't enough for actions to work — the agent needs this repo in its agent_repos_extra to actually run entrypoint/entrypoint. Found this the hard way while wiring path-router into a real account: the service_definition looked correctly registered but had no effect until the agent's repo list was updated.
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
agustincelentano
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HTTPRouterouting +container-scope-overrideblue/green sync) fromnullplatform/services, flattened to the repo root.specs/service-spec.json.tpl/README (kept alongside a generic placeholder, since PAE's live registration reads this enum directly — see commit558f4a4)..gitignore,Dockerfile,ci.yml) and adds a project-appropriate.gitignore.specs/install/istio, a working OpenTofu example that registers the service (mirrors thespecs/installconvention fromservices-rds), plus docs on wiringagent_repos_extrafor the agent.Test plan
terraform validatepasses forspecs/install/istioagainst the realtofu-modulessources.services-testing'sservice_definition_path_router/service_definition_channel_association_path_routerto point here,terraform planshowed the expected diff (repo pointer + additive domain enum), applied cleanly with no unrelated changes.agent_repos_extraon the live agent(s) that route path-router actions (seespecs/install/README.md— pending, not yet applied).services-rds,services-endpoint-exposer) and drop the temporary PAT currently used for private-repo access.🤖 Generated with Claude Code