Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kubernetes Custom needs an explicit way to select an IaC-owned ServiceAccount without enabling its IAM role/ServiceAccount lifecycle manager.
Add the optional
service_account_namescope capability and emit it in the deployment context. Empty/unset preserves current behavior. Inherited account provider defaults are deliberately ignored, so this opt-in does not change the identity of other scopes. Reject conflicting managed-IAM ownership and invalid Kubernetes names.This lets UI plugins Stage select the role and ServiceAccount declared in nullplatform/iac-null-runtime#115. Configure
service_account_name=ui-plugins-stageon that scope only after the infrastructure has been applied; leave managed IAM disabled.Validation: shell syntax check, JSON schema extraction/validation and all 84 deployment context tests passed. Six new tests exercise the real context builder: explicit selection, ignoring inherited defaults, both legacy paths, conflicting ownership and invalid names. The initial PR revision also passed the repository's complete Unit Tests, Go tests and ShellCheck; the updated CI reruns those checks.