docs(install): correct the Azure asset-repository limitation and file layout - #26
Merged
Merged
Conversation
… layout Two documentation defects that landed with the Azure install reference. The limitation named `s3-configuration` as one of the available asset-repository provider specifications. It is not one: it declares no `global.asset_repository_provider` mapping at all, it maps `bucket.name` to `aws.s3_assets_bucket` — which is what makes the AWS path resolve to the `s3://` URL `cloudfront/setup` parses. The specifications that do take the asset-repository role are `ecr` and `docker-server`, both container-registry shaped. Mixing the two categories obscured what Azure actually needs: either a Blob asset-repository provider, or an `azure-blob-configuration` counterpart to `s3-configuration`. The layout tree also drifted from the directories it documents: it was missing `azure/provider.tf`, and `aws/` had since gained `provider.tf` and `versions.tf`. Both examples now carry the same five files and the tree says so. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
agustincelentano
approved these changes
Sep 8, 2026
jcastiarena
changed the title
jcastiarena
force-pushed
the
fix/install-docs-asset-repo-and-layout
branch
from
September 9, 2026 12:05
4fdc8e5 to
0b237da
Compare
jcastiarena
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #20, which landed the Azure install reference with two documentation defects. Docs only — no HCL or workflow changes.
1. The asset-repository limitation named the wrong specifications
Both READMEs listed
s3-configurationas one of the available asset-repository provider specifications. It is not one.Checking the provider catalogue, exactly two specifications take the asset-repository role — the ones whose
mappingwritesrepository_providertoglobal.asset_repository_provider:ecrdocker-servers3-configurationdeclares no such mapping at all. It mapsbucket.nametoaws.s3_assets_bucket, and that is what makes the AWS path resolve to thes3://…URLdeployment/distribution/cloudfront/setupparses.Conflating the two categories obscured what Azure actually needs. The corrected text states it: either an Azure Blob asset-repository provider, or an
azure-blob-configurationcounterpart tos3-configuration. The limitation itself is unchanged and still real — a deployment cannot complete on Azure, because both available asset repositories are container-registry shaped andblob-cdn/setuprejects an image URI.The full explanation now lives in
static-files/README.mdonly;specs/install/README.mdcarries a two-line version and links to it. Keeping the same claim written out twice is how it came to be wrong in two places at once.2. The layout tree had drifted from the directories it documents
It was missing
azure/provider.tf(added late in #20), andaws/had since gainedprovider.tfandversions.tffrom #19. Both examples now carry the same five files, and the tree says so.Verification
The tree is checked against
git ls-filesrather than the working directory —azure/also holds a gitignored.terraform/and.terraform.lock.hclfrom a localtofu init, which must not appear in the documented layout:No
s3-configurationmention remains except the two that explain what it actually is.🤖 Generated with Claude Code