feat(agent): worker.security plaintext replaces insecure (alias kept) - #201
Draft
sebasnallar wants to merge 1 commit into
Draft
feat(agent): worker.security plaintext replaces insecure (alias kept)#201sebasnallar wants to merge 1 commit into
sebasnallar wants to merge 1 commit into
Conversation
The opt-out mode is now spelled `plaintext`; `insecure` is accepted as a deprecated alias and passed through verbatim, so existing values files render exactly what they render today. Unknown values abort the render instead of reaching the agent, where a typo silently means mTLS. Requires the controlplane-agent release that includes nullplatform/controlplane-agent#101: older agents do not know `plaintext` and fall back to mTLS. Only installs pinning image.tag to an older agent are affected; the default tag is latest. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
worker.securitydefault is nowplaintext(wasinsecure); comments invalues.yamland the README row updated.insecureis still accepted and passed through verbatim, so existing values files render the exact same pod spec as today. The agent maps it to plaintext and logs a deprecation warning (nullplatform/controlplane-agent#101).plaintext/mtls/insecurenow abort the render with a clear message, matching thegithub.appsvalidation style. Previously a typo reached the agent, which fails closed to mTLS with no error anywhere.Merge order
Draft until the controlplane-agent release containing nullplatform/controlplane-agent#101 is out. An older agent does not know
plaintext, treats it as unknown, and runs mTLS. The default image tag islatestwithpullPolicy: Always, so only installs pinningimage.tagto an older agent are exposed once that release exists.Test plan
helm templaterendersNP_WORKER_SECURITY=plaintextby default--set worker.security=plaintext|mtls|insecureeach pass through verbatim--set worker.security=yoloaborts the render with the validation messagehelm lint charts/agentpasses🤖 Generated with Claude Code