revert(ci): open release-please PR with app token instead of GITHUB_TOKEN - #197
Merged
Merged
Conversation
…HUB_TOKEN" This reverts commit e829496.
agustincelentano
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Por qué
Revierte #195. Ese cambio buscaba evitar el gate de aprobación manual de GitHub Actions (
action_required) en los workflows disparados porpull_requestsobre el PR de release, pero:nullplatform/tofu-modulestiene el mismorelease-pleasecorriendo con elGITHUB_TOKENdefault (identidadgithub-actions[bot]) y ya resolvió ese mismo problema de otra forma (ver fix(ci): trigger release PR auto-merge via workflow_run instead of pull_request #178) sin tocar la identidad que abre el PR.APP_RELEASE_ID) usada para el token nunca tuvo el permisoPull requests: write(solo se le dioContents: write, suficiente para elgh pr merge --admindeauto-merge-release.yml). El primer run tras mergear fix(ci): open release-please PR with app token instead of GITHUB_TOKEN #195 pudo crear la rama y el commit del release, pero falló al abrir el PR conResource not accessible by integration, dejando una rama huérfana (release-please--branches--main) sin PR.Fix real
El camino correcto es #178: cambiar el trigger de
auto-merge-release-prdepull_requestaworkflow_run, que no está sujeto al gate de aprobación de outside-collaborators (ya validado en producción ennullplatform/tofu-modules#479). Este PR solo deshace la parte de #195; #178 se mergea por separado.Test plan
mainhace querelease-please(conGITHUB_TOKENdefault) cree el release PR normalmente, y queauto-merge-release-pr(ahora víaworkflow_run) lo mergee sin quedar enaction_required.