Skip to content

fix: fall back to PATH when Windows Path is absent #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amtbsl wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: fall back to PATH when Windows Path is absent #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
191140e
fix: fall back to PATH on Windows
amtbsl Aug 29, 2026
b5cf664
test: cover Windows Path fallback
amtbsl Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,13 @@ const getPathInfo = (cmd, {
pathExt: optPathExt = process.env.PATHEXT,
delimiter: optDelimiter = delimiter,
}) => {
const pathEnvValue = optPath === undefined && isWindows ? process.env.Path : optPath
// If it has a slash, then we don't bother searching the pathenv.
// just check the file itself, and that's it.
const pathEnv = cmd.match(rSlash) ? [''] : [
// windows always checks the cwd first
...(isWindows ? [process.cwd()] : []),
...(optPath || /* istanbul ignore next: very unusual */ '').split(optDelimiter),
...(pathEnvValue || /* istanbul ignore next: very unusual */ '').split(optDelimiter),
]

if (isWindows) {
Expand Down
15 changes: 14 additions & 1 deletion test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const fs = require('fs')
const { basename, join, relative, sep, delimiter } = require('path')
const isWindows = process.platform === 'win32'

const ENV_VARS = { PATH: process.env.PATH, PATHEXT: process.env.PATHEXT }
const ENV_VARS = { PATH: process.env.PATH, Path: process.env.Path, PATHEXT: process.env.PATHEXT }
const PLATFORM = Object.getOwnPropertyDescriptor(process, 'platform')

const runTest = async (t, exec, expect, { platforms = ['posix', 'win32'], ..._opt } = {}) => {
Expand Down Expand Up @@ -114,6 +114,19 @@ t.test('find when executable', async t => {
})
})

t.test('falls back to process.env.Path on Windows', async t => {
const fixture = t.testdir({ 'foo.sh': 'echo foo\n' })
const foo = join(fixture, 'foo.sh')
fs.chmodSync(foo, 0o755)
delete process.env.PATH
process.env.Path = fixture

await runTest(t, basename(foo), foo, {
platforms: ['win32'],
pathExt: '.sh',
})
})

t.test('find all', async t => {
const cmdName = 'x.cmd'
const fixture = t.testdir({
Expand Down