fix(ci): use Node 22 for jsdom 30 compatibility - #8
Merged
Conversation
jsdom 30 pulls undici 8.x, which requires worker_threads.markAsUncloneable available only from Node 22.10+. CI was pinned to Node 20, causing vitest to fail before collecting any tests.
|
@coderabbitai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
package.jsonengines with undici 8.x / jsdom 30 requirement (>=22.19.0)Root cause
jsdom 30 depends on undici 8.x, which calls
worker_threads.markAsUncloneableat module load time. That API exists only from Node 22.10+, so vitest workers crashed on Node 20 before collecting tests (webidl.util.markAsUncloneable is not a function).Test plan
Made with Cursor