doc: clarify Worker execArgv vs Permission Model grants - #66124
yunshingng wants to merge 1 commit into
Conversation
|
Review requested:
|
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
Commit Queue failedThis pull request has multiple commits, but no landing policy was selected. Add
commit-queue-squash
The pull request was removed from the Commit Queue and labeled
commit-queue-failed
Full Commit Queue output |
Omit execArgv: the worker keeps the parent's CLI flags, including --permission and --allow-*. Explicit execArgv (including []) replaces inheritance and can drop those grants. That is intended. Documented after nodejs#65359. No runtime change. Refs: nodejs#65359 Signed-off-by: yunshingng <yunshingng25@gmail.com>
0df0f6c to
a30e532
Compare
Commit Queue failedThe pull request was removed from the Commit Queue and labeled
commit-queue-failed
Full Commit Queue output |
Description
Follow-up to #65359.
Rafael asked to keep the current runtime behavior and only clarify the docs.
This PR does not change
src/. It states:execArgv: the worker keeps the parent CLI flags (--permission,--allow-*if the parent has them).execArgv, including[]: inheritance is replaced; Permission Model grants from the parent are not kept unless listed again.Test plan