Skip to content

deps: update V8 to 15.2 - #65161

Open
targos wants to merge 27 commits into
nodejs:mainfrom
targos:v8-152
Open

deps: update V8 to 15.2#65161
targos wants to merge 27 commits into
nodejs:mainfrom
targos:v8-152

Conversation

@targos

@targos targos commented Aug 9, 2026

Copy link
Copy Markdown
Member

Refs: #64784

@nodejs-github-bot

nodejs-github-bot commented Aug 9, 2026 •
edited by targos
Loading

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8

@targos targos changed the title deps: update V8 to 15.2.124.7 deps: update V8 to 15.2 Aug 9, 2026
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Aug 9, 2026
@targos targos mentioned this pull request Aug 9, 2026
Open
@targos

targos commented Aug 9, 2026

Copy link
Copy Markdown
Member Author

I guess this is blocked by #64408 (https://github.com/nodejs/node/actions/runs/31307061482/job/93228984418?pr=65161)

@joyeecheung

joyeecheung commented Aug 10, 2026

Copy link
Copy Markdown
Member

Uploaded https://chromium-review.googlesource.com/c/v8/v8/+/8223266 to fix the Linux AArch64 build (haven't tested on real Linux AArch64 yet, but that's what the error message suggests)

hubot pushed a commit to v8/v8 that referenced this pull request Aug 13, 2026
@joyeecheung v8-scoped@luci-project-accounts.iam.gserviceaccount.com
[simd] Disable SVE implementation of array search for GCC
68cf9ec 
GCC requires SVE enabled for the entire translation unit and does
not expose raw __builtin_sve_* builtins on a per-function basis.
Fallback to Neon if it's not built by Clang.

Refs: nodejs/node#65161
Change-Id: I53a06fcf8f901ae0347044c6999463ce99215c45
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8223266
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Joyee Cheung <joyee@igalia.com>
Cr-Commit-Position: refs/heads/main@{#109230}
targos and others added 21 commits August 13, 2026 14:13
@targos
deps: update V8 to 15.2.124.9
f229070
@targos
deps: update Rust crates for V8 15.2.124.9
919bb0b
@targos
build: reset embedder string to "-node.0"
70d2f50
@targos
src: update NODE_MODULE_VERSION to 150
b65a010 
Major V8 updates are usually API/ABI incompatible with previous
versions. This commit adapts NODE_MODULE_VERSION for V8 15.2.

Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
@targos
deps: patch V8 to avoid duplicated zlib symbol
5ad8871 
PR-URL: nodejs#61898
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@StefanStojanovic @targos
deps: define V8_PRESERVE_MOST as no-op on Windows
f48938f 
It's causing linker errors with node.lib in node-gyp and potentially
breaks other 3rd party tools

Refs: nodejs#55784
PR-URL: nodejs#61898
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@targos
deps: remove problematic comment from v8-internal
bca9f0e 
GCC emits warnings because of the trailing backslashes.

PR-URL: nodejs#61898
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@danmcd @targos
deps: patch V8 for illumos
12cafb1 
illumos pointers are VA48, can allocate from the top of the 64-bit range
as well.

PR-URL: nodejs#61898
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@danmcd @targos
deps: support madvise(3C) across ALL illumos revisions
a4df191 
In illumos, madvise(3C) now takes `void *` for its first argument
post-illumos#14418, but uses `caddr_t` pre-illumos#14418. This fix will
detect if the illumos mman.h file in use is pre-or-post-illumos#14418 so
builds can work either way.

PR-URL: nodejs#61898
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@StefanStojanovic @targos
deps: patch V8 to fix Windows build
742eed5 
PR-URL: nodejs#61898
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@abmusse @targos
deps: fix V8 race condition for AIX
7d828f0 
aix: simplify OS::DecommitPages implementation

Replace complex mmap/munmap retry logic with mprotect + madvise
approach.

This fixes a race condition that was causing test failures in Node.js.
Node.js stress test was run with this fix and testing shows
0 failures out of 1000 runs of wpt/test-wasm-jsapi with this
patch compared to 224 failures without it.

Refs: nodejs#62647
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/7780464
PR-URL: nodejs#61898
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@targos
deps: fixup macros.h for GCC support
4fd114f 
Signed-Off-By: Michaël Zasso <targos@protonmail.com>
@joyeecheung @targos
deps: V8: cherry-pick 68cf9ecd884b
d356533 
Original commit message:

    [simd] Disable SVE implementation of array search for GCC

    GCC requires SVE enabled for the entire translation unit and does
    not expose raw __builtin_sve_* builtins on a per-function basis.
    Fallback to Neon if it's not built by Clang.

    Refs: nodejs#65161
    Change-Id: I53a06fcf8f901ae0347044c6999463ce99215c45
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8223266
    Reviewed-by: Igor Sheludko <ishell@chromium.org>
    Commit-Queue: Joyee Cheung <joyee@igalia.com>
    Cr-Commit-Position: refs/heads/main@{#109230}

Refs: v8/v8@68cf9ec
@targos @joyeecheung
tools: update V8 gypfiles for 14.8
ddc5a13 
Co-Authored-By: Joyee Cheung <joyeec9h3@gmail.com>
Signed-Off-By: Michaël Zasso <targos@protonmail.com>
@targos
tools: update V8 gypfiles for 14.9
16a633e 
Signed-Off-By: Michaël Zasso <targos@protonmail.com>
@targos
tools: update V8 gypfiles for 15.0
4a79372 
Signed-Off-By: Michaël Zasso <targos@protonmail.com>
@targos
tools: update V8 gypfiles for 15.1
f230ce7 
Signed-Off-By: Michaël Zasso <targos@protonmail.com>
@joyeecheung @targos
build: disable v8_postmortem_support
5a52c05 
Post-mortem libraries should use v8's debug_helper library instead.
@targos
src: migrate from deprecated xxxV2 APIs
05c8cac 
- Set/GetPrototype
- Holder

Signed-Off-By: Michaël Zasso <targos@protonmail.com>
@targos
src: migrate from v8::PropertyCallbackInfo<void>
a091ac4 
Signed-Off-By: Michaël Zasso <targos@protonmail.com>
@targos
test: update wpt Wasm jsapi expectations
130c5d8 
Signed-Off-By: Michaël Zasso <targos@protonmail.com>
joyeecheung and others added 5 commits August 13, 2026 14:15
@joyeecheung @targos
test: update test-heapdump-vm-script.js for new version of V8
f5af774 
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
@joyeecheung @targos
build: use ICU_UTIL_DATA_STATIC across V8
50b775e 
ICU_UTIL_DATA_SHARED had been removed since
https://crrev.com/c/1513615, but Node.js still defined
it and relied on the removed path on Windows, so the ICU
initialization in mksnapshot had been silently failing
since then. https://crrev.com/c/7679153 made the failure
visible so the build started breaking on Windows. Fix it
by always using ICU_UTIL_DATA_STATIC since we already compile
the ICU data statically in.

Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
@joyeecheung @targos
src: fix external reference registration for new CFunction lifetime
3056163 
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
@joyeecheung @targos
test: update for new V8 serialization format
3f87950 
V8 bumped its wire-format version from 0x0f to 0x10. Update the
expected hex in test-v8-serdes, and derive the v8 header bytes
dynamically in test-runner-v8-deserializer so it tracks future
bumps automatically.

Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
@targos
test: avoid worker in shared value conveyor test
52dcedd 
V8 no longer supports JSON.parse on worker isolates while the shared
string table is enabled. Since --harmony-struct enables that table and
Node workers parse process.config during bootstrap,
use direct MessageChannel instead of a worker.

Signed-Off-By: Michaël Zasso <targos@protonmail.com>
@richardlau

richardlau commented Aug 13, 2026

Copy link
Copy Markdown
Member

FWIW https://chromium-review.googlesource.com/c/v8/v8/+/8236132 was opened by @sravani1510 to address the AIX build failure that is occurring on our V8 nightly builds.

@targos

targos commented Aug 13, 2026

Copy link
Copy Markdown
Member Author

@nodejs/platform-windows We're hitting a weird error on Windows:

https://github.com/nodejs/node/actions/runs/31699320590/job/94444346312?pr=65161

  Unexpected command-line argument "src/debug/debug-wasm-obects.q", expected a .tq file.
C:\Program Files\Microsoft Visual Studio\18\Enterprise\MSBuild\Microsoft\VC\v180\Microsoft.CppCommon.targets(254,5): error MSB8066: Custom build for '..\..\out\Release\\torque.exe' exited with code 3. [D:\a\node\node\tools\v8_gypfiles\run_torque.vcxproj]

This wrong path doesn't exist in the code.

@targos

targos commented Aug 13, 2026

Copy link
Copy Markdown
Member Author

@legendecas Can you help with the perfetto build?

@legendecas
build: fix cppgc_base perfetto source scraper
6bb8632 
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@targos @nodejs-github-bot @joyeecheung @richardlau @StefanStojanovic @danmcd @abmusse @legendecas