lib,src: improve histogram implementation - #65024
Open
jasnell wants to merge 4 commits into
Open
Conversation
Several improvements: 1. In histogram-inl, Add previous locked only this->mutex while reading the other's fields unsafely. 2. In histogram.cc, PrepareCB now uses ContainerOf 3. In histogram.cc, BigInt value range is checked 4. In histogram.js, simplified impl and reduced duplication 5. In event_loop_delay.js, use a more consistent constructor Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode/Opus
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode/Opus
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode/Opus
Adds new analytical APIs to Histogram * histogram.ccdf(value) * histogram.cdf(value) * histogram.countAt(value) * histogram.ksTest(other) * histogram.kurtosis * histogram.linearBuckets(stepSize) * histogram.logBuckets(first, base) * histogram.percentilesAt(percentiles) * histogram.shewness On RecordableHistogram * histogram.recordCorrected(val, expectedInterval) * histogram.subtract(other) Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell
added
the
semver-minor
nodejs-github-bot
added
c++
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #65024 +/- ##
==========================================
+ Coverage 90.30% 90.32% +0.01%
==========================================
Files 759 759
Lines 247634 248121 +487
Branches 46684 46798 +114
==========================================
+ Hits 223630 224106 +476
- Misses 15467 15475 +8
- Partials 8537 8540 +3
🚀 New features to boost your workflow:
|
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several improvements:
reading the other's fields unsafely.
There is one potentially/technically breaking change. In Record, we were previously silently truncating when Bigint conversion was lossy. Now it throws. This is technically a bug fix. It's exceedingly unlikely that anyone is depending on the former behavior so I'd rather land this as a minor.
Signed-off-by: James M Snell jasnell@gmail.com
Assisted-by: Opencode/Opus