sqlite: refactor error helpers and user function pointers - #62794
Open
thisalihassan wants to merge 1 commit into
Open
sqlite: refactor error helpers and user function pointers#62794thisalihassan wants to merge 1 commit into
thisalihassan wants to merge 1 commit into
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #62794 +/- ##
=======================================
Coverage 90.14% 90.14%
=======================================
Files 744 744
Lines 242518 242500 -18
Branches 45685 45683 -2
=======================================
- Hits 218611 218606 -5
+ Misses 15396 15390 -6
+ Partials 8511 8504 -7
🚀 New features to boost your workflow:
|
Contributor
Author
|
@nodejs/sqlite @geeksilva97 can I get a review please? |
Contributor
|
Sure. Will take a look. |
geeksilva97
approved these changes
May 6, 2026
Contributor
|
cc @nodejs/cpp-reviewers |
github-actions
Bot
removed
the
request-ci
Collaborator
Member
|
Is this okay to land @geeksilva97, or do we need an additional review from CPP team? |
Contributor
PR LGTM. We can get it landed, I was just looking for another eye before moving further. We need a new CI run since it's been a while |
github-actions
Bot
added
request-ci-failed
Contributor
Failed to start CI- Validating Jenkins credentials ✔ Jenkins credentials valid - Querying data for job/node-test-pull-request/73204/ [SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/30204902769 |
Contributor
Author
|
@geeksilva97 @trivikr do I need to rebase or something? |
Contributor
yes, please |
Signed-off-by: Ali Hassan <ali-hassan27@outlook.com>
thisalihassan
force-pushed
the
sqlite-refactor-error-and-udf-ptrs
branch
from
July 27, 2026 08:44
7d3237b to
fe5a33c
Compare
geeksilva97
added
request-ci
github-actions
Bot
added
request-ci-failed
Contributor
Failed to start CI- Validating Jenkins credentials ✔ Jenkins credentials valid - Querying data for job/node-test-pull-request/73204/ [SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/30286474954 |
trivikr
added
request-ci
github-actions
Bot
added
request-ci-failed
Contributor
Failed to start CI- Validating Jenkins credentials ✔ Jenkins credentials valid - Querying data for job/node-test-pull-request/73204/ [SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/31053714586 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small independent refactors.
CreateSQLiteErroroverloadsBaseObjectWeakPtrfor user functions (style consistency)