fix(react): reflect system theme in toggle icon - #1013
Open
mgalore wants to merge 1 commit into
Open
Conversation
Signed-off-by: Jonathan Amponsah <82057176+mgalore@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ovflowd
reviewed
Aug 9, 2026
| * Theme switcher. | ||
| */ | ||
| const Toggle = () => { | ||
| const [themePreference, setThemePreference] = useTheme(); |
Member
There was a problem hiding this comment.
this seems like an unrelate rename.
ovflowd
reviewed
Aug 9, 2026
| * @param {boolean} systemSupportsDarkMode - Whether the OS currently prefers dark mode. | ||
| * @returns {'light'|'dark'} The theme currently displayed by the page. | ||
| */ | ||
| export const getDisplayedTheme = (preference, systemSupportsDarkMode) => { |
ovflowd
reviewed
Aug 9, 2026
Member
There was a problem hiding this comment.
@avivkeller I'm fairly sure this can be done on ui-components side? I thought this was done over there already, wondering if a change here is really needed. TRhe solution also doesn feel elegant...
Member
|
also it's not seem fixing the issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
systemFixes #903
Validation
npm testnode --run test:cinode --run lintnode --run format:checkSigned-off-by: Jonathan Amponsah 82057176+mgalore@users.noreply.github.com