[BIG] Adding spoQC to spatialaxe and many other changes - #206
Merged
Conversation
…other spoQC modules
…in.nf for utils_nfcore_spatialaxe
dev to spoqc branch to avoid merge conflic
… to acocunt for it cahgnes to subworkflow/spatialdata/main.nf, coordinat_mode.nf.test*, spatialaxe.nf
Collaborator
Author
|
Finally 😅 all tests pass @kubranarci could you please check again |
kubranarci
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Adding spoQC
subworkflows/local/spoqc/main.nfplus 31 new local modules undermodules/local/spoQC/(ambient,analysis_category,analysis_cluster,analysis_overview,annotation,bubble,cell,cellcycle,combine_masks,doublet,finalreport,general,hqcr_celltype,hqcr_ident,hqpr_bounding_box,hqpr_celltype,hqpr_clustering,hqpr_metrices,hqpr_refinement,hqtr_ac,hqtr_bounding_box,hqtr_celltype,hqtr_clustering,hqtr_metrices,hqtr_qv,hqtr_refinement,marker,model,transcript,void,whole_slide), each with its ownmain.nf,meta.yml, and nf-test suite (tests/main.nf.test+ snapshot).workflows/spatialaxe.nf.bin/spatialdata_write.pysupport for spoQC's SpatialData output.conf/tests/test_spoqc.config,conf/tests/test_full_spoqc.configComment
Note
The tool will be released soon. It comes with proper documentation and spatialaxe will reference this documentation.
2. spatialaxe resource-label rework
conf/base.config: singleprocess_high/process_low-style labels with a combinatorial label system;process_{tiny,low,mid,high,xl}_cpus,_mem, and_timelabels, each scaling withtask.attempt.3. nf-schema plugin upgrade (2.5.1 → 2.7.2)
nextflow.config: bumped the plugin version.subworkflows/nf-core/utils_nfschema_plugin/main.nf: added acli_typecastinput, renamedparametersSchema→parameters_schemaacross option maps, fixed--helptext resolution.subworkflows/nf-core/utils_nextflow_pipeline/main.nf: rewrotedumpParametersToJSONto usegroovy.json.JsonGeneratorwith converters forPath/Duration/MemoryUnit/VersionNumber, replacing the oldJsonOutput/FilesExapproach.subworkflows/local/utils_nfcore_spatialaxe_pipeline/main.nf: passes the newcli_typecastargument through.nextflow_schema.json: cleanup — removed redundant"default": falseentries, added"default": trueforcell_segmentation_only, added numeric defaults formax_x/max_y, normalized float defaults, unicode-escapedµm.modules.json/ro-crate-metadata.json: regenerated to match.4. Bigger test-data support
nf-core/unzipmodule usage so the pipeline can unpack the larger test dataset.assets/samplesheet_full.csv,conf/test_full.config5. Samplesheet redefintion
sample,bundle,image,annotation,stainings: samplesheet allows for two additional optional columnsannotation,stainingsthat are useful for the QC subworkflow.6. Rework of subworkflow and pipeline for proper
qcmodespatialdata_write_meta_merge/main.nf: Change to subworkflow to account for properqcmode.bin/spatialdata_write.py: Adding anallmode to set all available features toTrue, which is important for QC.bin/spatialdata_write.pysupport for spoQC's SpatialData output.PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).