fix(SetupChecks): accept order-independent X-Robots-Tag directives - #64571
Merged
Merged
Conversation
This addresses a portion of the requests in Issue #37409. Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
requested review from
icewind1991,
leftybournes,
provokateurin and
salmart-dev
and removed request for
a team
September 19, 2026 18:02
icewind1991
approved these changes
Sep 19, 2026
Signed-off-by: Josh <josh.t.richards@gmail.com>
come-nc
approved these changes
Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses part of the requests in Issue #37409 by making the
X-Robots-Tagsetup check accept the required directives regardless of their order.The check now behaves as follows:
noindex,nofollow→ acceptednofollow, noindex→ acceptednoindex, nofollow, noarchive→ rejectednoindex→ rejectednofollow→ rejectedAdditional or missing directives continue to produce a warning. Whitespace and capitalization are normalized before comparison.
Added coverage for:
X-Robots-TagdirectivesIf additional directives (after confirming they're compatible) are deemed acceptable, those can be added in a stacked PR after this is merged. EDIT: Added in a follow-up PR: #64573
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)