Skip to content

fix(SetupChecks): accept order-independent X-Robots-Tag directives - #64571

Merged
come-nc merged 3 commits into
masterfrom
jtr/fix-setupChecks-value-ordering
Sep 19, 2026
Merged

come-nc merged 3 commits into
masterfrom
jtr/fix-setupChecks-value-ordering

Conversation

@joshtrichards

@joshtrichards joshtrichards commented Sep 19, 2026

Copy link
Copy Markdown
Member
  • Resolves: #

This addresses part of the requests in Issue #37409 by making the X-Robots-Tag setup check accept the required directives regardless of their order.

The check now behaves as follows:

  • noindex,nofollow → accepted
  • nofollow, noindex → accepted
  • noindex, nofollow, noarchive → rejected
  • noindex → rejected
  • nofollow → rejected

Additional or missing directives continue to produce a warning. Whitespace and capitalization are normalized before comparison.

Added coverage for:

  • Reordered X-Robots-Tag directives
  • Additional directives remaining invalid

If additional directives (after confirming they're compatible) are deemed acceptable, those can be added in a stacked PR after this is merged. EDIT: Added in a follow-up PR: #64573

TODO

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

This addresses a portion of the requests in Issue #37409.

Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards added this to the Nextcloud 36 milestone Sep 19, 2026
@joshtrichards
joshtrichards requested a review from a team as a code owner September 19, 2026 18:02
@joshtrichards
joshtrichards requested review from icewind1991, leftybournes, provokateurin and salmart-dev and removed request for a team September 19, 2026 18:02
Signed-off-by: Josh <josh.t.richards@gmail.com>
@come-nc
come-nc merged commit fb5ef92 into master Sep 19, 2026
155 checks passed
@come-nc
come-nc deleted the jtr/fix-setupChecks-value-ordering branch September 19, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants