fix(proxy): preserve percent-encoded image URLs in proxy link - #13506
Open
ChristophWurst wants to merge 1 commit into
Open
fix(proxy): preserve percent-encoded image URLs in proxy link#13506ChristophWurst wants to merge 1 commit into
ChristophWurst wants to merge 1 commit into
Conversation
linkToRoute() routes the src through Symfony's UrlGenerator, whose QUERY_FRAGMENT_DECODED map rewrites %252F back to %2F. That single character diverged from the value the HMAC was signed over, so the proxy rejected signed CDN image URLs with HTTP 401. Append src to the query with our own single encoding so it round-trips intact. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
ChristophWurst
added
bug
3. to review
AI assisted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
linkToRoute() routes the src through Symfony's UrlGenerator, whose QUERY_FRAGMENT_DECODED map rewrites %252F back to %2F. That single character diverged from the value the HMAC was signed over, so the proxy rejected signed CDN image URLs with HTTP 401. Append src to the query with our own single encoding so it round-trips intact.
Assisted-by: Claude:claude-opus-4-8
Fixes #13493
馃 AI (if applicable)