Conversation
Picks up nextcloud/viewer#2587 by mexthecat, which was right and had nothing to stand on: the list it adds to is filtered against the server's enabled preview providers, and none of them claimed image/jp2, so the entry was dropped again on every server. nextcloud/server#64603 adds the provider, so the entry now means something wherever an admin enables it, which is how tiff beside it has always worked. Co-authored-by: mexthecat <mexthecat@users.noreply.github.com> Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
added
status: review
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
=======================================
Coverage 88.11% 88.11%
=======================================
Files 37 37
Lines 2625 2626 +1
Branches 558 558
=======================================
+ Hits 2313 2314 +1
Misses 305 305
Partials 7 7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mexthecat opened nextcloud/viewer#2587 back in October 2024 to add
image/jp2to this list. It was the right change with nothing behind it, which is probably why it stalled: the list is filtered against the server's enabled preview providers, and none of them handled jp2, so the entry was dropped again on every server.nextcloud/server#64603 adds that provider, so the entry now means something. Their
Co-authored-byis on the commit.That PR needs to land first. On its own this does nothing rather than anything wrong, since the filter drops what no provider backs.
jp2 goes in the preview list rather than beside the browser formats because nothing decodes it client side. I checked:
<img>andcreateImageBitmapboth fail in Chromium and Firefox, and libgd has no JPEG 2000 support either. The server rendering it is all the support there is, which is the arrangementimage/tiffhas always had.Worth saying plainly: providers like this are off until an admin enables them, so most servers still will not open a
.jp2.Two tests, one each way: it opens where the server reports a provider for jp2, and it does not where the server reports only jpeg.
👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.