Skip to content

[NAE-2286] Group API - #423

Open
renczesstefan wants to merge 40 commits into
release/7.0.0from
NAE-2286
Open

[NAE-2286] Group API#423
renczesstefan wants to merge 40 commits into
release/7.0.0from
NAE-2286

Refactor `GroupServiceImpl`: add null and empty checks for group memb…

95ff03e
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Sep 16, 2026 in 1m 30s

Quality Gate failed

Failed conditions
3.5% Coverage on New Code (required ≥ 60%)
4.5% Duplication on New Code (required ≤ 3%)
D Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check failure on line 562 in nae-user-ce/src/main/java/com/netgrif/application/engine/auth/service/GroupServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

ReDoS via unsanitized user input in GroupServiceImpl.search() 

See more on https://sonarcloud.io/project/issues?id=netgrif_application-engine&issues=AaBdG-COUckrGjfNcJnw&open=AaBdG-COUckrGjfNcJnw&pullRequest=423

Check warning on line 8 in nae-object-library/src/main/java/com/netgrif/application/engine/objects/dto/request/group/GroupSearchRequestDto.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'java.io.Serializable'. 

See more on https://sonarcloud.io/project/issues?id=netgrif_application-engine&issues=AaBdG99mUckrGjfNcJnl&open=AaBdG99mUckrGjfNcJnl&pullRequest=423

Check warning on line 38 in nae-object-library/src/main/java/com/netgrif/application/engine/objects/auth/domain/ActorTransformer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this empty statement. 

See more on https://sonarcloud.io/project/issues?id=netgrif_application-engine&issues=AaCpHVpf290FDhlKR2j-&open=AaCpHVpf290FDhlKR2j-&pullRequest=423

Check warning on line 555 in application-engine/src/main/java/com/netgrif/application/engine/petrinet/service/ProcessRoleService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused private "deleteRolesOfNetFromGroup" method. 

See more on https://sonarcloud.io/project/issues?id=netgrif_application-engine&issues=AaBdG93rUckrGjfNcJng&open=AaBdG93rUckrGjfNcJng&pullRequest=423

Check warning on line 57 in nae-user-ce/src/main/java/com/netgrif/application/engine/auth/service/DefaultLoggedUserFactory.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove useless curly braces around statement 

See more on https://sonarcloud.io/project/issues?id=netgrif_application-engine&issues=AaCpHVrs290FDhlKR2kA&open=AaCpHVrs290FDhlKR2kA&pullRequest=423

Check failure on line 190 in application-engine/src/main/java/com/netgrif/application/engine/auth/web/GroupController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal " has failed!" 9 times. 

See more on https://sonarcloud.io/project/issues?id=netgrif_application-engine&issues=AaBdG964UckrGjfNcJnk&open=AaBdG964UckrGjfNcJnk&pullRequest=423

Check failure on line 568 in nae-user-ce/src/main/java/com/netgrif/application/engine/auth/service/GroupServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

ReDoS via unsanitized user input in GroupServiceImpl.search() 

See more on https://sonarcloud.io/project/issues?id=netgrif_application-engine&issues=AaBdG-COUckrGjfNcJnx&open=AaBdG-COUckrGjfNcJnx&pullRequest=423

Check warning on line 30 in nae-user-ce/src/main/java/com/netgrif/application/engine/auth/service/DefaultLoggedUserFactory.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove useless curly braces around statement 

See more on https://sonarcloud.io/project/issues?id=netgrif_application-engine&issues=AaCpHVrs290FDhlKR2j_&open=AaCpHVrs290FDhlKR2j_&pullRequest=423

Check warning on line 22 in nae-user-ce/src/main/java/com/netgrif/application/engine/auth/service/UserFactoryImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=netgrif_application-engine&issues=AaBdG-BwUckrGjfNcJnr&open=AaBdG-BwUckrGjfNcJnr&pullRequest=423

Check failure on line 293 in nae-user-ce/src/main/java/com/netgrif/application/engine/auth/service/GroupServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Group cannot be null" 6 times. 

See more on https://sonarcloud.io/project/issues?id=netgrif_application-engine&issues=AaBdG-COUckrGjfNcJnu&open=AaBdG-COUckrGjfNcJnu&pullRequest=423

Check warning on line 36 in nae-object-library/src/main/java/com/netgrif/application/engine/objects/auth/domain/ActorTransformer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this empty statement. 

See more on https://sonarcloud.io/project/issues?id=netgrif_application-engine&issues=AaCpHVpf290FDhlKR2j9&open=AaCpHVpf290FDhlKR2j9&pullRequest=423

Check warning on line 15 in nae-user-ce/src/main/java/com/netgrif/application/engine/auth/service/AuthorizationServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=netgrif_application-engine&issues=AaBdG9-NUckrGjfNcJnq&open=AaBdG9-NUckrGjfNcJnq&pullRequest=423

Check warning on line 10 in nae-user-common/src/main/java/com/netgrif/application/engine/auth/repository/GroupRepository.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'org.springframework.data.mongodb.core.query.Criteria'. 

See more on https://sonarcloud.io/project/issues?id=netgrif_application-engine&issues=AaBdG9-BUckrGjfNcJnn&open=AaBdG9-BUckrGjfNcJnn&pullRequest=423

Check warning on line 562 in application-engine/src/main/java/com/netgrif/application/engine/petrinet/service/ProcessRoleService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Invoke method(s) only conditionally. 

See more on https://sonarcloud.io/project/issues?id=netgrif_application-engine&issues=AaBdG93rUckrGjfNcJne&open=AaBdG93rUckrGjfNcJne&pullRequest=423

Check warning on line 16 in nae-user-ce/src/main/java/com/netgrif/application/engine/auth/service/AuthorizationServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This block of commented-out lines of code should be removed. 

See more on https://sonarcloud.io/project/issues?id=netgrif_application-engine&issues=AaBdG9-NUckrGjfNcJnp&open=AaBdG9-NUckrGjfNcJnp&pullRequest=423

Check warning on line 562 in application-engine/src/main/java/com/netgrif/application/engine/petrinet/service/ProcessRoleService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

No need to call "toString()" method as formatting and string conversion is done by the Formatter. 

See more on https://sonarcloud.io/project/issues?id=netgrif_application-engine&issues=AaBdG93rUckrGjfNcJni&open=AaBdG93rUckrGjfNcJni&pullRequest=423

Check failure on line 563 in nae-user-ce/src/main/java/com/netgrif/application/engine/auth/service/GroupServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

ReDoS via unsanitized user input in GroupServiceImpl.search() 

See more on https://sonarcloud.io/project/issues?id=netgrif_application-engine&issues=AaBdG-COUckrGjfNcJnv&open=AaBdG-COUckrGjfNcJnv&pullRequest=423

Check warning on line 4 in application-engine/src/test/java/com/netgrif/application/engine/workflow/service/TaskServiceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'com.netgrif.application.engine.TestHelper'. 

See more on https://sonarcloud.io/project/issues?id=netgrif_application-engine&issues=AaCpHVeB290FDhlKR2j6&open=AaCpHVeB290FDhlKR2j6&pullRequest=423

Check warning on line 534 in application-engine/src/main/java/com/netgrif/application/engine/petrinet/service/ProcessRoleService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

No need to call "toString()" method as formatting and string conversion is done by the Formatter. 

See more on https://sonarcloud.io/project/issues?id=netgrif_application-engine&issues=AaBdG93rUckrGjfNcJnh&open=AaBdG93rUckrGjfNcJnh&pullRequest=423

Check warning on line 520 in application-engine/src/main/java/com/netgrif/application/engine/petrinet/service/ProcessRoleService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused private "deleteRolesOfNetFromUser" method. 

See more on https://sonarcloud.io/project/issues?id=netgrif_application-engine&issues=AaBdG93rUckrGjfNcJnf&open=AaBdG93rUckrGjfNcJnf&pullRequest=423

Check warning on line 317 in application-engine/src/test/java/com/netgrif/application/engine/auth/web/AuthenticationControllerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "mock". 

See more on https://sonarcloud.io/project/issues?id=netgrif_application-engine&issues=AaBdG9zHUckrGjfNcJnd&open=AaBdG9zHUckrGjfNcJnd&pullRequest=423

Check failure on line 258 in application-engine/src/main/java/com/netgrif/application/engine/auth/web/GroupController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "] has failed!" 8 times. 

See more on https://sonarcloud.io/project/issues?id=netgrif_application-engine&issues=AaBdG964UckrGjfNcJnj&open=AaBdG964UckrGjfNcJnj&pullRequest=423

Check warning on line 32 in nae-object-library/src/main/java/com/netgrif/application/engine/objects/auth/domain/ActorTransformer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this empty statement. 

See more on https://sonarcloud.io/project/issues?id=netgrif_application-engine&issues=AaCpHVpf290FDhlKR2j7&open=AaCpHVpf290FDhlKR2j7&pullRequest=423

Check warning on line 10 in nae-user-ce/src/main/java/com/netgrif/application/engine/auth/service/AuthorizationServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=netgrif_application-engine&issues=AaBdG9-NUckrGjfNcJno&open=AaBdG9-NUckrGjfNcJno&pullRequest=423

Check warning on line 34 in nae-object-library/src/main/java/com/netgrif/application/engine/objects/auth/domain/ActorTransformer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this empty statement. 

See more on https://sonarcloud.io/project/issues?id=netgrif_application-engine&issues=AaCpHVpf290FDhlKR2j8&open=AaCpHVpf290FDhlKR2j8&pullRequest=423
View more details on SonarQubeCloud