feat(i18n): add Turkish (tr-TR) locale support - #342
Merged
Conversation
Adds Turkish as a full UI language: - New `Language::Turkish` variant across rust/src/settings/types.rs and rust/src/locale.rs, wired to the tr-TR Fluent bundle. - New rust/src/locale/tr-TR.ftl with all 758 locale keys translated. - Bridge/TS types and GeneralTab language picker updated to expose turkish as a selectable option. - New README.tr-TR.md (full translation) and language-switcher links added to README.md and the other localized READMEs. - Unit tests added/updated for the new locale in locale_cmd.rs, rust/src/locale/tests.rs, rust/src/settings/tests.rs, and GeneralTab.test.tsx / bridge.test.ts. Verified locally: - node apps/desktop-tauri/scripts/check-locale-drift.mjs -> OK, 758 keys match - cargo test --manifest-path rust/Cargo.toml locale -> 16 passed - cargo test --manifest-path apps/desktop-tauri/src-tauri/Cargo.toml locale -> 9 passed - pnpm --dir apps/desktop-tauri test -> 258 passed (42 files) - cargo fmt --all -- --check -> clean
Collaborator
|
Thanks for the PR, I will review this ASAP. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Turkish (
tr-TR) as a full UI language option.Language::Turkishvariant acrossrust/src/settings/types.rsandrust/src/locale.rs, wired to a new tr-TR Fluent bundle.rust/src/locale/tr-TR.ftlwith all 758 locale keys translated.turkishas a selectable option.README.tr-TR.md(full translation) and a language-switcher link added toREADME.mdand the other localized READMEs.locale_cmd.rs,rust/src/locale/tests.rs,rust/src/settings/tests.rs, andGeneralTab.test.tsx/bridge.test.ts.Testing
Ran from repo root (MSVC toolchain; the default GNU toolchain in my environment is missing
dlltool.exe):Results:
check-locale-drift: OK, 758 keys match between Rust and TSrust\Cargo.tomllocale tests: 16 passedlocale_strings_roundtrip_turkish)cargo fmt --check: cleanpnpm test: 258 passed across 42 filesNo UI/tray visual behavior changed beyond adding one more entry to the existing language
<select>, so no CUA Driver capture was produced for this PR; happy to add one if maintainers want a screenshot of the new option in the Settings > General language picker.