Remove unused flag images from the admin resource - #737
Open
DateFTP wants to merge 1 commit into
Open
Conversation
Author
|
Confirmation in the request to the ip2c folder for obtaining flag images. |
Author
|
@qaisjp I personally apologize for the tag, it's just that reviewing my pool is very long( |
Member
|
Please resolve conflicts |
Author
|
What specific conflicts am I supposed remove? If it’s a stock resource, I suggested removing the flags from the ip2c admin resource; the resource that uses the flags — what else can I do? |
Contributor
|
Overwrite the changes in this repo with your changes, I did a PR to reduce the file size of PNG images and that included a few here and git calls that a conflict for some reason |
DateFTP
force-pushed
the
remove-unused-flag-images
branch
from
August 24, 2026 23:18
615b3a5 to
2608155
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The country flags under
[admin]/admin/client/images/flags/are no longer needed.The admin resource has been loading player flags from the separate
ip2cresource for a while now (admin_main.luareferences:ip2c/client/images/flags/), so these local copies are never used. Since theip2cresource ships its own flag set, keeping duplicates here just adds ~200 files to the repository for nothing.This removes the whole
flagsfolder and nothing else. No code or config references these files, andmeta.xmldoes not list them either.Confirmed nothing else in the resource points at
client/images/flags, so this should be a safe cleanup.