Fix Splash Window (Prevent memory leak when fetching GetDpiForWindow) - #5271
Open
iManGaaX wants to merge 2 commits into
Open
Fix Splash Window (Prevent memory leak when fetching GetDpiForWindow)#5271iManGaaX wants to merge 2 commits into
iManGaaX wants to merge 2 commits into
Conversation
replaced LoadLibrary("user32") with GetModuleHandleA("user32.dll"). LoadLibrary increases the dll is reference count without calling FreeLibrary, causing a resource leak. since user32.dll is already loaded in Win32 gui apps, using GetModuleHandleA safely retrieves the function pointer without leaking memory
iManGaaX
changed the title
iManGaaX
changed the title
Member
|
There is no resource leak. You are never going to unload user32.dll in a process. |
Author
The intention was just to follow best practices by avoiding unnecessary reference count increments when GetModuleHandleA is sufficient for already loaded modules |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaced LoadLibrary("user32") with GetModuleHandleA("user32.dll"). LoadLibrary increases the dll is reference count without calling FreeLibrary, causing a resource leak. since user32.dll is already loaded in Win32 gui apps, using GetModuleHandleA safely retrieves the function pointer without leaking memory