feat: expose code property on Encoder class - #53
Open
sumanjeet0012 wants to merge 1 commit into
Open
Conversation
acul71
requested changes
Sep 7, 2026
acul71
left a comment
Contributor
There was a problem hiding this comment.
Request changes — missing newsfragment (blocker)
Thanks for this clean, focused fix for #47. The Encoder.code property matches the issue proposal and looks correct; CI and local make lint / typecheck / test / docs-ci all pass.
Blocker
Please add a towncrier newsfragment:
- Path:
newsfragments/47.feature.rst - Content (example):
Added a public ``Encoder.code`` property exposing the multibase prefix byte. - Must end with a trailing newline
Newsfragments are mandatory for approval on this repo.
Also recommended (non-blocking)
- Rebase onto current
origin/master(branch is ~6 commits behind; dry-run merge is clean today). - Note overlap with open PR #54 on the same files — coordinate merge order.
- Optional: assert another encoding for
.code(e.g.base16→b"f") and/or mentionencoder.codein the README Encoder example.
Happy to re-review once 47.feature.rst is added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #47
Description
This pull request adds a public
.codeproperty to theEncoderclass.Changes
self._codec.codevia a read-only propertycode.py-multibaseinto alignment withgo-multibase, which exposes the encoding code viaEncoder.Encoding().encoder.codereturns the correct multibase prefix byte.