[WIP] Add front-end triage automation for Messaging System - #6600
Open
dmose wants to merge 2 commits into
Open
Conversation
Add the desktop Messaging System (about:welcome, feature callouts, Spotlight, Infobars) as a triaged area: a SLACK_CHANNELS entry for "Firefox :: Messaging System", the matching README routing row and component list entry, and the source locations (browser/components/asrouter/, browser/components/aboutwelcome/, toolkit/components/messaging-system/) in the triage rules so localization has somewhere to look.
There was a problem hiding this comment.
Pull request overview
This PR extends the existing frontend-triage agent’s component-to-Slack routing to include the Firefox :: Messaging System component, so auto-applied triage runs can notify the appropriate team channel.
Changes:
- Add
Firefox :: Messaging System→#omc-triagerouting in the agent config. - Add/extend unit test coverage to assert correct routing for the new component.
- Update README and Hackbot rules documentation to include the Messaging System scope and source-area pointers.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| agents/frontend-triage/tests/test_notify.py | Adds an assertion that Firefox :: Messaging System routes to #omc-triage. |
| agents/frontend-triage/README.md | Documents Messaging System as in-scope and adds it to the routing table. |
| agents/frontend-triage/hackbot_agents/frontend_triage/rules/frontend-triage.md | Updates the rules to include Messaging System and related source areas. |
| agents/frontend-triage/hackbot_agents/frontend_triage/config.py | Adds the Firefox :: Messaging System entry to SLACK_CHANNELS. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
40
to
+44
| (`.sys.mjs`, IDL, C++); the installer under `browser/installer/windows/nsis/` | ||
| (NSIS `.nsi`/`.nsh`). Find the module, the markup or layout, and any relevant pref | ||
| (often `modules/libpref/init/all.js`, or `app.update.*` for the updater) that | ||
| governs the behaviour. Use the `investigator` subagent for deep searches. | ||
| (NSIS `.nsi`/`.nsh`), Messaging System under `browser/components/asrouter/`, | ||
| `browser/components/aboutwelcome/`, `toolkit/components/messaging-system/` | ||
| (JS/JSM, CSS, XUL/HTML, JSON, JSON Schema). Find the module, the markup or layout, | ||
| and any relevant pref (often `modules/libpref/init/all.js`, or `app.update.*` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sets up the front-end triage agent to also work with the
Firefox :: Messaging Systemcomponent.Before this gets merged, three things need to happen:
[ ] The OMC team Technical Point-Of-Contact should reach out to coordinate with @msujaws
[ ] If the OMC team has decided that they want a Slack channel other than
#omc-triage, this PR needs updating.[ ] Remove [WIP] from the PR title
[ ] At least @msujaws should review. Jared, I believe this includes all the changes you suggested. I have run the changed agent using
docker composeto execute the front end triage agent on the command line and it seemed to behave reasonably. I haven't had time to test hackbot driving the agent.