Skip to content

feat(quoter-bot): add delegated KMS signer - #214

Open
haydenshively wants to merge 5 commits into
docs/quoter-operator-maker-kms-signerfrom
feat/quoter-bot-delegated-kms-signer
Open

feat(quoter-bot): add delegated KMS signer#214
haydenshively wants to merge 5 commits into
docs/quoter-operator-maker-kms-signerfrom
feat/quoter-bot-delegated-kms-signer

Conversation

@haydenshively

@haydenshively haydenshively commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Separate the funded maker from the direct AWS KMS signer.
  • Route every write through one simulated, policy-checked transaction queue.
  • Remove the signing middleware and update configuration, readiness, deployment, and operator docs.

Checks

  • Bot-kit and quoter-bot typechecks
  • pnpm lint, pnpm format, pnpm knip, and pnpm build
  • Quoter build and JSDoc/TypeDoc build
  • 2,848 non-fork tests
  • Independent funds-at-risk review: no findings

Fork tests were added but not run because RPC_URL_8453 is not configured.

@haydenshively
haydenshively added this pull request to stack #215 September 11, 2026 04:32
@haydenshively
haydenshively marked this pull request as ready for review September 11, 2026 04:33
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-11T19:54:02.951185Z d2471d1 Manual request
🔒 Security Review Completed 2026-09-11T20:02:12.113016Z d2471d1 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 potential issues.

2 flags not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)

Devin Review

Comment thread packages/bot-kit/src/signer.ts Outdated
Comment thread bots/quoter-bot/docker-compose.yml

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 00f9c6d38f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread bots/quoter-bot/src/infrastructure/transaction/quoter-transaction-executor.ts Outdated
Comment thread packages/bot-kit/src/signer.ts Outdated
Comment thread services/quoter-signer/Dockerfile
Comment thread bots/quoter-bot/scripts/deploy-railway.ts
@haydenshively haydenshively self-assigned this Sep 11, 2026
@haydenshively

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: d2471d1617

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: d2471d1617

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant