Replace bespoke hosting growth with connected services - #26
Merged
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9ff20b130d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Owner
Author
|
Final verification before merge:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make a connected-services architecture the canonical path for new
server-setupinstallations instead of continuing to grow the custom deployment platform.Service boundary
Implementation
setup.shas the canonical installer/integratorservices/compose.ymland optional Dokploy Traefik overlay--replace-legacyplus--confirm-legacy-cutover-readybefore stopping the old nginx/webhook/status unitsValidation
setup.shbash -n, read-only preflight, fail-closed missing acknowledgement, and successful confirmed dry-runScope
This intentionally does not automate migration of existing
server.confapplications into Dokploy. A same-server transition requires a maintenance window because both edges need ports 80/443. The preflight and rollback contract protect the initial edge replacement; application/data migration and any later rollback remain explicit operator work.PR #25's provider-specific DNS UI/CLI, host runtime bootstrap, and further bespoke deployment growth are superseded. Its registry collision validation is the only candidate for a later, narrowly scoped legacy-safety change; it is not mixed into this architecture PR.