Bump rust-lightning pins to lsp-0.2.5 - #44
Open
amackillop wants to merge 1 commit into
Open
Conversation
Moves all twelve lightning-* git pins from lsp-0.2.0 (based on upstream v0.2) to lsp-0.2.5 (d6f87a44d), our fork rebased onto upstream v0.2.5. Picks up the 0.2.1-0.2.5 security and bug fixes, most notably the funds-theft fix for forwarding nodes (#4854), the possiblyrandom HashDoS fix (#4719), and the LSPS persistence stuck-after-one-failure fix (#4597). The rebase moves splicing to production feature bit 63 (upstream 0.2.2), and the fork additionally dual-advertises the legacy prototype bit 155 and accepts it at the splice_channel gate, so un-upgraded clients keep splicing until client version telemetry (MDK-424) ships and confirms the bit can be sunset. The ACINQ carve-out (strip 155, eclair chokes on both bits) is preserved. No code changes required: the fork API surface is unchanged and the 0.2.3 DefaultMessageRouter change (unblinded reply paths for nodes with public channels, the LND BOLT12 workaround) is behavioral only.
amackillop
force-pushed
the
austin_bump-rust-lightning-0.2.5
branch
from
August 7, 2026 20:53
bd802e2 to
64a0588
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps all twelve
lightning-*git pins fromlsp-0.2.0(upstream v0.2 base) tolsp-0.2.5(d6f87a44d), our fork rebased onto upstream v0.2.5. Companion to moneydevkit/rust-lightning#28 — review that PR for the rebase itself; this one is just the pin move.Picks up the 0.2.1–0.2.5 security fixes: funds-theft fix for forwarding nodes (#4854), possiblyrandom HashDoS (#4719), LSPS persistence stuck-after-one-failure (#4597), anchor reserve underestimates, async-persist restart force-closure bug, and more.
Behavioral notes:
DefaultMessageRouter(0.2.3): generates unblinded reply paths for nodes with public channels — the upstream workaround for LND peers refusing to forward BOLT12 messages.splice_channel(0.2.1): fails fast when the peer advertises neither splicing bit; the LSPS4 error path already releases the coin reservation.No code changes needed — the fork API surface is unchanged.
Test evidence (plain cargo per the repo's known fmt/lint debt; nix-provided bitcoind 27.1 + electrs-esplora for integration tests):
d6f87a44d):cargo check --all-targetsclean;cargo test --lib33/33; the three splice integration tests (splice_channel+ both splice-reservation tests) 3/3 on a clean run — one run had a single timing flake, rerun passed.f0308f89a; the restore only adds a feature bit): 37/38 — the one failure (channel_full_cycle_0conf,ChannelSplicingFailedon the follow-upsplice_in) reproduces identically on currentlsp-0.7.0with the old pins, i.e. pre-existing; see comment below. Worth a separate ticket.