feat(tests): Additional MIP-8 coverage - #52
Merged
Conversation
Only the commitment scheme separates the two blocks' state roots. Co-Authored-By: Claude <claude-opus-5>
Clears every slot of a page between surviving pages, covering both the branch-collapse and branch-retained trie shapes. Co-Authored-By: Claude <claude-opus-5>
Covers the paged root diverging from the keccak MPT, a fully cleared page returning to its prior root, and Alloc routing state_root by commitment. Co-Authored-By: Claude <claude-opus-5>
Refills after N clears stay at PAGE_BASE_COST until the counter climbs back above its starting peak. Co-Authored-By: Claude <claude-opus-5>
mijovic
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes ENG-1132
Fills gaps in coverage found by @mijovic . All tests confirmed to pass via runloop on
v0.16.1Greptile Summary
This PR expands MIP-8 test coverage for pageified storage commitments, fork migration, and SSTORE growth accounting.
Confidence Score: 5/5
The PR appears safe to merge; no concrete correctness, security, or test-validity issues remain.
The added tests use compatible storage representations, isolate gas measurements from the page under test, and exercise the intended MIP-8 commitment and growth behavior without introducing production changes.
Important Files Changed
Reviews (1): Last reviewed commit: "test(mip8): pin the negative state-growt..." | Re-trigger Greptile
Context used: