Skip to content

fix(crosssection): make view x/y override symmetric, validate input - #2805

Merged
wpbonelli merged 1 commit into
modflowpy:developfrom
wpbonelli:crosssection
Aug 19, 2026
Merged

fix(crosssection): make view x/y override symmetric, validate input#2805
wpbonelli merged 1 commit into
modflowpy:developfrom
wpbonelli:crosssection

Conversation

@wpbonelli

@wpbonelli wpbonelli commented Aug 12, 2026

Copy link
Copy Markdown
Member

little fixes for #2782

  • only view="x" could force a direction, view="y" couldn't
  • make invalid values an error instead of silently using "x"
  • state that view has no effect for row/column-based cross sections in the docstring

@wpbonelli wpbonelli added this to the 3.11 milestone Aug 12, 2026
@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.7%. Comparing base (556c088) to head (2126aed).
⚠️ Report is 199 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2805      +/-   ##
===========================================
+ Coverage     55.5%    72.7%   +17.2%     
===========================================
  Files          644      661      +17     
  Lines       124135   133026    +8891     
===========================================
+ Hits         68947    96832   +27885     
+ Misses       55188    36194   -18994     
Files with missing lines Coverage Δ
flopy/plot/crosssection.py 64.7% <100.0%> (-2.4%) ⬇️

... and 582 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wpbonelli
wpbonelli marked this pull request as ready for review August 12, 2026 03:31

@jlarsen-usgs jlarsen-usgs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes all look good to me

@wpbonelli
wpbonelli merged commit 65b6c55 into modflowpy:develop Aug 19, 2026
20 checks passed
@wpbonelli
wpbonelli deleted the crosssection branch August 19, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants