docs: document reviewing a GitHub PR by piping gh pr diff into hunk patch - #672
Open
habakan wants to merge 1 commit into
Open
docs: document reviewing a GitHub PR by piping gh pr diff into hunk patch#672habakan wants to merge 1 commit into
habakan wants to merge 1 commit into
Conversation
Contributor
|
PR author is not in the allowed authors list. |
|
@habakan is attempting to deploy a commit to the Modem Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Documents the workflow for reviewing a GitHub pull request without checking it out:
website/.../workflows/files-and-patches.md: new "Review a GitHub pull request" section withgh pr diff 123 --patch | hunk patch -and thehunk-prshell function suggested by @benvinegar in feat(diff): review a GitHub pull request with--pr#663.README.md: one example line in "Working with raw files and patches".Why
In #663 I proposed a
hunk diff --prflag for #465, and the feedback was that documenting and sharing the existing pipe workflow is preferable to coupling hunk togh. This PR takes that direction. Closing #663 in favor of this.Related: #465
This is my first contribution here, so feel free to adjust wording or placement.