JIT quantized-kernel fixes; adjacent minor underscore fix - #4372
Open
dwijenpatel wants to merge 1 commit into
Open
JIT quantized-kernel fixes; adjacent minor underscore fix#4372dwijenpatel wants to merge 1 commit into
dwijenpatel wants to merge 1 commit into
Conversation
dwijenpatel
marked this pull request as ready for review
August 21, 2026 23:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small PR fixing #4350
results_per_simdgroupparam is unused, but needed to fix the compilation issue, and the underlying implementations hardcode 4.fp_qmv_fastwas mentioned in the issue, but has the correct param count (and actually usesresults_per_simdgroup). The other 3 mentioned are fixed in this PR.test_quantizedsuite under JIT surfaced two pre-existing, unrelated errors - removing underscores in twoget_qmm_nax_kernel_wrappedcalls to reference correct function names, re-ran tests to verify all fixes (37/37, AOT unchanged).MLX_METAL_JIT=ONjob to CI might be worth doing at some point, to proactively surface this class of bugs.Pair-programming with Claude, attempting to do useful work as a side-effect of deep-diving into GPU kernel optimization.