Prevent zero-copy adoption across dtype conversion - #4367
Draft
declanhealy2 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a NumPy buffer is adopted through the zero-copy path, the current conversion code can return a view with the destination dtype even when the source dtype differs. This corrupts values, for example float64 input requested as complex64.
The patch passes the source MLX dtype into the no-copy check and rejects adoption when source and destination dtypes differ, allowing the existing conversion path to preserve values.
Focused validation:
python python/tests/test_zero_copy.py(7 passed).Radar observed this through Array-API backend parity; no Radar tolerance or test was weakened.