build: stop recording npm registry URLs in lockfiles - #1395
Merged
Jason Johnston (jasonjoh) merged 2 commits intoSep 14, 2026
Merged
Jason Johnston (jasonjoh) merged 2 commits into
Jason Johnston (jasonjoh) merged 2 commits into
Conversation
Add npm's omit-lockfile-registry-resolved setting to both tutorial projects and remove registry URLs without changing dependency metadata. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Jason Johnston (jasonjoh)
September 14, 2026 13:26
View session
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved issues; installation, build, and lint validation passed.
Review tier: Lite
Findings: None
What changed in this PR
Configures both tutorials to omit npm registry URLs from lockfiles while preserving dependency metadata.
Changes:
- Adds
omit-lockfile-registry-resolved=trueto both.npmrcfiles. - Removes registry
resolvedfields from both lockfiles. - Preserves lockfile version 3 and dependency integrity data.
| File | Summary |
|---|---|
user-auth/graphtutorial/package-lock.json |
Removes registry URLs. |
user-auth/graphtutorial/.npmrc |
Enables URL omission. |
app-auth/graphapponlytutorial/package-lock.json |
Removes registry URLs. |
app-auth/graphapponlytutorial/.npmrc |
Enables URL omission. |
Files not reviewed (2)
- app-auth/graphapponlytutorial/package-lock.json: Generated file
- user-auth/graphtutorial/package-lock.json: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Jason Johnston (jasonjoh)
merged commit Sep 14, 2026
f437efd
into
microsoftgraph:main
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
omit-lockfile-registry-resolved=trueinapp-auth/graphapponlytutorialanduser-auth/graphtutorial.resolvedfields from both lockfiles.Validation
npm config get omit-lockfile-registry-resolvedreturnedtruein both project roots.npm cicompleted in both project roots with Node.js 24.19.0 and npm 11.19.0.npm run buildandnpm run lintpassed in both tutorials after copyingappSettings.example.tstoappSettings.ts, matching CI.