Fix test:api on windows - #4917
Merged
Wesley Wigham (weswigham) merged 2 commits intoAug 19, 2026
Merged
Conversation
Wesley Wigham (weswigham)
requested review from
Andrew Branch (andrewbranch) and
Jake Bailey (jakebailey)
and
a balanced review from Copilot
August 19, 2026 22:06
Wesley Wigham (weswigham)
enabled auto-merge
August 19, 2026 22:09
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Windows API test discovery and normalizes path assertions across platforms.
Changes:
- Runs API tests directly from the native-preview workspace.
- Normalizes
outDirbefore comparison in async and generated sync tests.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
Herebyfile.mjs |
Invokes Node’s test runner directly. |
_packages/native-preview/test/async/api.test.ts |
Normalizes the asserted output path. |
_packages/native-preview/test/sync/api.test.ts |
Mirrors the async test update. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Ryan Cavanaugh (RyanCavanaugh)
approved these changes
Aug 19, 2026
Jake Bailey (jakebailey)
pushed a commit
to jakebailey/TypeScript
that referenced
this pull request
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Something about the chained
npmcommands made the globbing pattern for test lookup fail to find any files on windows. Just inlining the command from thepackage.jsonintoHerebyfile.mjsworks fine as a workaround, though.Also fixes the apparently broken-on-windows API test.