Toggle matching table borders - #3464
Open
Julia Roldi (juliaroldi) wants to merge 3 commits into
Open
Julia Roldi (juliaroldi) wants to merge 3 commits into
Julia Roldi (juliaroldi) wants to merge 3 commits into
Conversation
|
Julia Roldi (juliaroldi)
marked this pull request as ready for review
September 11, 2026 20:07
| } | ||
|
|
||
| if (!comparisonStyle) { | ||
| comparisonStyle = editor.getDocument().createElement('div').style; |
Collaborator
There was a problem hiding this comment.
why need to create a DIV?
Contributor
Author
There was a problem hiding this comment.
I was to normalize the border color before comparing the border color being set with the previous one. I refactored the code to use parseColor before comparing the color, then we do not need the div anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update
applyTableBorderFormatto toggle the targeted table borders off when every selected border already matches the requested format, while preserving the existing apply behavior when any target differs. Normalize equivalent CSS border values before comparison and add coverage for border operations across selection shapes, directions, repeated operations, and table defaults.How to test
yarn test:fast --testPathPattern=applyTableBorderFormat.