[Mermaid 1/4] Add literal fenced-code Markdown support - #3460
Open
Kyle Rubenok (krubenok) wants to merge 3 commits into
Open
Kyle Rubenok (krubenok) wants to merge 3 commits into
Kyle Rubenok (krubenok) wants to merge 3 commits into
Conversation
This was referenced Sep 9, 2026
Collaborator
|
Hi, can you share a design spec about how is this whole feature working? Such as the input, output, technical design. In general, the design of content model allows you to override any element processor to add your own content handling. So not all those customized content need to change the core code. You can first try to explore this direction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First layer of a four-PR Mermaid integration stack. This layer has no Mermaid dependency.
This extends the existing Markdown converter rather than claiming overall CommonMark compliance. Block content in pipe-table cells remains subject to the existing serializer's limitations.
Validation
yarn b: passed.yarn eslint: passed.yarn test:fast: 6,394 tests passed, exit code 0. Karma prints a page-reload warning after the successful total.Stack
PR 1 targets upstream
master. Each later PR targets the preceding branch inkrubenok/roosterjsfor an incremental review. Promote the dependent layers upstream after their prerequisites merge. Lower-layer fixes are merged forward without rewriting published history.Validation follow-up
Declaration generation also passes after the import and named-return-type fixes. Firefox job
102362718902in run34319476781failed before tests because the existing npm feed returned503 Service Unavailablefor@types/jasmine@3.5.10; that infrastructure failure is separate from the code fixes.