Fix desktop focus management and accessibility action handling - #4314
Open
Jason Morse (JasonVMo) wants to merge 12 commits into
Open
Jason Morse (JasonVMo) wants to merge 12 commits into
Jason Morse (JasonVMo) wants to merge 12 commits into
Conversation
Preserve focus stories and apply focused smoke selectors to the merged static and WDIO runners. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Bundle size reportTree-shaken production Metro bundles. Component costs are relative to their platform shell; shell costs are absolute.
The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms impacted
Description of changes
Fix desktop focus ownership, activation, and focus visuals across the agentic component library, using shipped V1 Win32 behavior as the Windows compatibility reference and preserving AppKit-specific behavior on macOS.
ThemedRoot, stable scene input-modality settings, focused-owner subscriptions, and shared-controller popup input boundaries. Apply the scene consistently to Storybook chrome and previews without remounting on theme changes.resolveAccessibilityActionhelper and an accessibility authoring directory in Framework Base. Checkbox, Switch, and Tab share declaration/name resolution, caller-preserving deduplication, and exact dispatch matching: lowercasetoggle/selecton Windows Fabric and the existingToggle/Selectnames on Win32/macOS custom-action paths.foundation-settingstest failure.packages/agentic/components/WIN32-FOCUS-PLAN.mdwith executed evidence and remaining gates.Related issues
This PR advances the following work items, but does not complete their full acceptance criteria:
No automatic issue-closing keywords are used because these are broader tracking issues rather than fully resolved individual defects.
Verification
Completed locally on macOS against the changes in this branch:
yarn lage test --no-cache: 80 tasks passed.The original 18-case suite also passed with real input and zero skips on both Windows Fabric and Win32 before the final follow-up repairs. Those earlier results are not presented as a rerun of the final 22-case catalog.
Toggle/Selectcasing.Remaining validation and platform limits
accessibilityState.disabled/selectedprojection to AXEnabled/AXSelected. Focus exclusion, component-owned state, and activation guards are tested separately, not substituted for native AX state evidence.Pull request checklist