docs: clarify Trainer runner-count tuning - #576
Open
Jimmy Wang (JimmyWang0417) wants to merge 1 commit into
Open
docs: clarify Trainer runner-count tuning#576Jimmy Wang (JimmyWang0417) wants to merge 1 commit into
Jimmy Wang (JimmyWang0417) wants to merge 1 commit into
Conversation
Author
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a runner-count tuning section to the parallelization tutorial for issue #366. It explains:
n_runnersmaps to rollout concurrency and how the deprecatedn_workersalias relates to it;n_runners=1is useful for debugging and a baseline.The guidance avoids claiming a universal optimum or inventing benchmark numbers.
Fixes #366
Validation
mkdocs build --strictPRE_COMMIT_HOME=/tmp/agent-lightning-366-precommit pre-commit run --files docs/tutorials/parallelize.md --show-diff-on-failuregit diff --checkAI assistance was used to prepare this patch. I reviewed the changed lines and ran the checks above.