Skip to content

feat(k8s): add image-readiness preflight for VERL training - #568

Open
baibizhe (SII) (baibizhe) wants to merge 1 commit into
microsoft:mainfrom
baibizhe:feature/k8s-image-readiness
Open

feat(k8s): add image-readiness preflight for VERL training#568
baibizhe (SII) (baibizhe) wants to merge 1 commit into
microsoft:mainfrom
baibizhe:feature/k8s-image-readiness

Conversation

@baibizhe

Copy link
Copy Markdown

Summary

  • publish a leased intersection of images reported by Ready, schedulable Kubernetes nodes
  • filter training and validation rows by the images in their rendered Jobs before Ray initializes
  • fail guarded rollouts promptly when fresh readiness data is unavailable or an image is missing
  • keep the feature disabled by default and preserve the source JSONL files

Motivation

With imagePullPolicy: IfNotPresent, a missing locally built :openai image can leave a rollout in ImagePullBackOff while GPU training waits until the rollout timeout. In the setup reported in #567, preflight identified 190 of 6,343 training rows and 126 of 474 validation rows whose rendered Jobs referenced unavailable images.

Kubelet limits Node.status.images to 50 entries by default, so the documentation explains using nodeStatusMaxImages: -1 for large preloaded-image sets.

Validation

  • 54 focused tests passed
  • 121 functional repository tests and 3 isolated package-metadata tests passed
  • Ruff check and format passed
  • BasedPyright reported 0 errors and 0 warnings
  • independent code review found no critical or important issues

Closes #567

Copilot AI lite review requested due to automatic review settings August 26, 2026 15:17
@baibizhe

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CPU-side Kubernetes image-readiness preflight for VERL training

3 participants