Fix ApplicationLanguages::PrimaryLanguageOverride() - #6421
Conversation
|
@hoshiizumia |
|
Mahdi Hosseini (@ghost1372) I dont know😕. The WindowsAppSdk repo cannot be compiled currently. Related APIs are all Windows SDK encapsulations, and I don't know why it happened, which includes #6346. |
|
What's the reason for this PR? What does it solve? I don't see any context 🤷🏻♂️ |
Bro, what are you talking about. The comments already included. For packaged applications, As a result, Windows persists the override correctly, but after For packaged applications this change delegates the getter to Unpackaged applications continue using the process-local value, The setter also allows an empty string so callers can clear the |
|
First. Don't "bro" me. You don't know me and I expect to be addressed with respect. Second. The comment asks you "does this solve this issue?" And your answer was clearly "I don't know". Third. It's common courtesy to link an open issue and/or add an explanation to the PR, including the problem, the solution, and telling how the solution was tested. |
A microsoft employee must use /azp run to validate using the pipelines below.
WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.
For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.