Skip to content

fix(60223): add Promise.try() to ESNext lib - #60232

Merged
Gabriela Araujo Britto (gabritto) merged 5 commits into
microsoft:mainfrom
dirkluijk:fix-promise-try
Nov 6, 2024
Merged

fix(60223): add Promise.try() to ESNext lib#60232
Gabriela Araujo Britto (gabritto) merged 5 commits into
microsoft:mainfrom
dirkluijk:fix-promise-try

Conversation

@dirkluijk

@dirkluijk Dirk Luijk (dirkluijk) commented Oct 15, 2024

Copy link
Copy Markdown
Contributor

Fixes #60223

@typescript-bot TypeScript Bot (typescript-bot) added the For Milestone Bug PRs that fix a bug with a specific milestone label Oct 15, 2024
@dirkluijk
Dirk Luijk (dirkluijk) force-pushed the fix-promise-try branch 2 times, most recently from dbb3235 to 1407fab Compare October 15, 2024 08:13
@dirkluijk

Dirk Luijk (dirkluijk) commented Oct 15, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This is my first contribution to this project. Please let me know if this PR needs anything else. :)

Maybe this can still make it to the final 5.7 release?

@IllusionMH

Andrii Dieiev (IllusionMH) commented Oct 15, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Shouldn't it be es2025 instead?
es2024 was finished/approved in June https://github.com/tc39/ecma262/releases/tag/es2024

@dirkluijk

Dirk Luijk (dirkluijk) commented Oct 15, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I wasn't fully aware of how the TC39 finalization process works. Shall I move it to ESNext, or to ES2025? I will move it to ESNext instead.

@dirkluijk Dirk Luijk (dirkluijk) changed the title fix(60223): add Promise.try() to ES2024 lib fix(60223): add Promise.try() to ESNext lib Oct 15, 2024
@dirkluijk

Dirk Luijk (dirkluijk) commented Oct 15, 2024

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

@dirkluijk

Dirk Luijk (dirkluijk) commented Oct 15, 2024

Copy link
Copy Markdown
Contributor Author

Should be fixed.

jakebailey
Jake Bailey (jakebailey) reviewed Oct 15, 2024
View reviewed changes
Comment thread src/lib/esnext.promise.d.ts Outdated
@dirkluijk

Dirk Luijk (dirkluijk) commented Oct 15, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Gabriela Araujo Britto (@gabritto) I just updated the PR to allow a PromiseLike return value instead of a Promise.

ljharb
Jordan Harband (ljharb) reviewed Oct 15, 2024
View reviewed changes
Comment thread src/lib/esnext.promise.d.ts Outdated
@dirkluijk

Dirk Luijk (dirkluijk) commented Oct 16, 2024

Copy link
Copy Markdown
Contributor Author

Updated the PR to allow passing additional arguments.

ljharb
Jordan Harband (ljharb) reviewed Oct 16, 2024
View reviewed changes

@ljharb Jordan Harband (ljharb) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

gabritto
Gabriela Araujo Britto (gabritto) reviewed Oct 16, 2024
View reviewed changes
Comment thread src/lib/esnext.promise.d.ts Outdated
@dirkluijk

Dirk Luijk (dirkluijk) commented Oct 28, 2024

Copy link
Copy Markdown
Contributor Author

When will this PR be merged? 😉

@jakebailey

Jake Bailey (jakebailey) commented Oct 28, 2024

Copy link
Copy Markdown
Member

TS 5.7 beta is already out, and we don't do anything bug bugfixes or editor improvements after beta. The linked issue is milestoned as 5.8.

@gabritto
Gabriela Araujo Britto (gabritto) merged commit 60dd512 into microsoft:main Nov 6, 2024
@dirkluijk
Dirk Luijk (dirkluijk) deleted the fix-promise-try branch December 17, 2024 15:05
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakebailey Jake Bailey (jakebailey) jakebailey left review comments
@gabritto Gabriela Araujo Britto (gabritto) gabritto approved these changes
+1 more reviewer
@ljharb Jordan Harband (ljharb) ljharb left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@gabritto Gabriela Araujo Britto (gabritto)

Labels

For Milestone Bug PRs that fix a bug with a specific milestone

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update ESNext with Promise.try (stage 4)

7 participants

@dirkluijk @IllusionMH @jakebailey @ljharb @gabritto @sandersn @typescript-bot