Type definitions for 'Symbols as WeakMap keys' (#76) - #54195
Merged
Ron Buckton (rbuckton) merged 3 commits intoJun 9, 2023
Conversation
TypeScript Bot (typescript-bot)
added
the
For Uncommitted Bug
TypeScript Bot (typescript-bot)
added
For Milestone Bug
Leo Elmecker-Plakolm (leoelm)
marked this pull request as ready for review
May 31, 2023 21:43
Leo Elmecker-Plakolm (leoelm)
force-pushed
the
le/symbol-as-weak-keys
branch
from
June 1, 2023 12:39
723ec0d to
0f47664
Compare
Nathan Shively-Sanders (sandersn)
requested review from
Ron Buckton (rbuckton) and
Sheetal Nandi (sheetalkamat)
June 1, 2023 23:33
Ron Buckton (rbuckton)
approved these changes
Jun 8, 2023
Ron Buckton (rbuckton)
left a comment
Ron Buckton (rbuckton)
left a comment
Contributor
There was a problem hiding this comment.
I can re-review and merge once conflicts are resolved.
Leo Elmecker-Plakolm (leoelm)
force-pushed
the
le/symbol-as-weak-keys
branch
from
June 8, 2023 20:44
0f47664 to
03938b9
Compare
Contributor
Author
|
Rebase is now done and all seems to be looking good still. |
Support symbols in WeakMap, WeakSet, WeakRef and FinalizationRegistry Signed-off-by: Leo Elmecker <lelmeckerpla@bloomberg.net>
Leo Elmecker-Plakolm (leoelm)
force-pushed
the
le/symbol-as-weak-keys
branch
from
June 9, 2023 16:47
03938b9 to
8db37ee
Compare
Ron Buckton (rbuckton)
approved these changes
Jun 9, 2023
| interface WeakMapConstructor { | ||
| new <K extends object = object, V = any>(entries?: readonly (readonly [K, V])[] | null): WeakMap<K, V>; | ||
| readonly prototype: WeakMap<object, any>; | ||
| new <K extends WeakKey = WeakKey, V = any>(entries?: readonly [K, V][] | null): WeakMap<K, V>; |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #52534.
Adding symbol type support to
WeakMap,WeakSet,WeakRefandFinalizationRegistry.The above has been achieved by retrospectively introducing an interface,
WeakTypesused for the definition of compatible types for the above mentioned structures.