Revert "Better typings for Promise.resolve(), like #31117 (#33074)" - #50227
Closed
Nathan Shively-Sanders (sandersn) wants to merge 1 commit into
Closed
Revert "Better typings for Promise.resolve(), like #31117 (#33074)"#50227Nathan Shively-Sanders (sandersn) wants to merge 1 commit into
Nathan Shively-Sanders (sandersn) wants to merge 1 commit into
Conversation
TypeScript Bot (typescript-bot)
added
Author: Team
For Uncommitted Bug
Member
|
TypeScript Bot (@typescript-bot) cherry-pick this to release-4.8 |
Contributor
|
Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the task to cherry-pick this into |
Contributor
|
Hey Daniel Rosenwasser (@DanielRosenwasser), I've opened #50229 for you. |
TypeScript Bot (typescript-bot)
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Aug 9, 2022
Component commits: c28ee65 Revert "Better typings for Promise.resolve(), like microsoft#31117 (microsoft#33074)" This reverts commit 040c121.
TypeScript Bot (typescript-bot)
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Aug 11, 2022
Component commits: c28ee65 Revert "Better typings for Promise.resolve(), like microsoft#31117 (microsoft#33074)" This reverts commit 040c121. Co-authored-by: Nathan Shively-Sanders <nathansa@microsoft.com>
Member
Author
|
Having reviewed the vs code and DT failures, I think the original change is good, and should ship in 4.9 now that vscode updated to avoid the compile errors. I'll close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 040c121.
#33074 (comment)