Skip to content

Skip unsupported EC curves in KeysInUse tests #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Maxwell Moyer-McKee (mamckee) merged 2 commits into from
Aug 26, 2026
+20 −3
Merged

Skip unsupported EC curves in KeysInUse tests #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64f4c98
Skip unsupported EC curves in tests
mamckee Aug 25, 2026
aa6b915
PR comments
mamckee Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ cmake_minimum_required(VERSION 3.13.0)
include(CheckIncludeFile)

project(SymCrypt-OpenSSL
VERSION 1.11.0
VERSION 1.11.1
DESCRIPTION "The SymCrypt engine and provider for OpenSSL (SCOSSL)"
HOMEPAGE_URL "https://github.com/microsoft/SymCrypt-OpenSSL")

Expand Down
21 changes: 19 additions & 2 deletions test/KeysInUseTest/KeysInUseTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
#include "scossl_helpers.h"
#include "keysinuse.h"

#include <openssl/ec.h>
#include <openssl/evp.h>
#if OPENSSL_VERSION_MAJOR == 3
#include <openssl/core_names.h>
Expand Down Expand Up @@ -91,9 +92,7 @@ static KEYSINUSE_TEST_KEY testKeys[] = {
{EVP_PKEY_RSA, 2048, nullptr, nullptr, 0, {}},
{EVP_PKEY_RSA, 3072, nullptr, nullptr, 0, {}},
{EVP_PKEY_RSA, 4096, nullptr, nullptr, 0, {}},
#ifdef NID_X9_62_prime192v1 // This curve is not available on Azure Linux 3
{EVP_PKEY_EC, NID_X9_62_prime192v1, nullptr, nullptr, 0, {}},
#endif
{EVP_PKEY_EC, NID_secp224r1, nullptr, nullptr, 0, {}},
{EVP_PKEY_EC, NID_X9_62_prime256v1, nullptr, nullptr, 0, {}},
{EVP_PKEY_EC, NID_secp384r1, nullptr, nullptr, 0, {}},
Expand Down Expand Up @@ -1624,6 +1623,18 @@ SCOSSL_STATUS keysinuse_test_generate_keys()
}
else if (testKeys[i].keyType == EVP_PKEY_EC)
{
EC_GROUP *ecGroup = EC_GROUP_new_by_curve_name(testKeys[i].keygenParams);
if (ecGroup == NULL)
{
const char *curveName = OBJ_nid2sn(testKeys[i].keygenParams);
printf("Skipping unsupported curve %s\n", curveName != NULL ? curveName : "<unknown>");
ERR_clear_error();
EVP_PKEY_CTX_free(ctx);
ctx = NULL;
continue;
}
EC_GROUP_free(ecGroup);

if (EVP_PKEY_CTX_set_ec_paramgen_curve_nid(ctx, testKeys[i].keygenParams) <= 0)
{
TEST_LOG_OPENSSL_ERROR("EVP_PKEY_CTX_set_ec_paramgen_curve_nid failed")
Expand Down Expand Up @@ -1963,6 +1974,12 @@ int main(int argc, char** argv)

for (KEYSINUSE_TEST_KEY testKey : testKeys)
{
if (testKey.pkey == NULL)
{
// Key generation was skipped for this entry (unsupported curve).
continue;
}

if (testKey.keyType == EVP_PKEY_RSA)
{
printf("Testing RSA sign with size %d\n", testKey.keygenParams);
Expand Down