Unpin transformers - #2622
Merged
Merged
Unpin transformers#2622
Conversation
shaahji
requested review from
Xiaoyu Z (xiaoyu-work)
and
a lite review from Copilot
and removed request for
Copilot
August 12, 2026 21:12
Xiaoyu Z (xiaoyu-work)
previously approved these changes
Aug 12, 2026
5 tasks
Contributor
|
This will also unblock MoE Quantization PRs - #2610 |
Resolves security issue found in v5.3.0 (last version available before the pinned version). Fixed tests that were failing because of the upgrade.
shaahji
force-pushed
the
shaahji/unpin_transformers
branch
from
August 13, 2026 00:32
db923e7 to
f6cb981
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Olive’s test dependency management to stop pinning transformers and adjusts a couple of tests/helpers to be compatible with newer transformers behaviors.
Changes:
- Remove the
<5.4.0upper bound ontransformersin the test requirements. - Ensure locally-saved tiny Llama models include a trivial tokenizer to avoid hub/tokenizer assumptions during metadata serialization.
- Relax/adjust assertions around
AutoConfigmodule paths for Phi3 to match currenttransformersbehavior (especially withtrust_remote_code).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/requirements-test.txt | Removes the transformers version pin in the test dependency set. |
| test/passes/pytorch/test_rtn.py | Saves a trivial tokenizer alongside a locally-saved tiny Llama model used in RTN tests. |
| test/model/test_hf_model.py | Updates Phi3 config module assertions to be compatible with current module loading behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Ti-Tai Wang (titaiwangms)
previously approved these changes
Aug 13, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
shaahji
enabled auto-merge (squash)
August 13, 2026 18:02
Ti-Tai Wang (titaiwangms)
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unpin transformers
Resolves security issue found in v5.3.0 (last version available before the pinned version).
Checklist before requesting a review
lintrunner -a(Optional) Issue link