fix deprecated pandas as_matrix usage - #1035
Open
Navin Prasath (athena0247) wants to merge 1 commit into
Open
Navin Prasath (athena0247) wants to merge 1 commit into
Navin Prasath (athena0247) wants to merge 1 commit into
Conversation
Replace the deprecated DataFrame.as_matrix() API with DataFrame.to_numpy() to restore compatibility with modern pandas versions.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Other lesson-local copies still use deprecated as_matrix() calls.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Replaces deprecated pandas as_matrix() usage in the shared time-series utility.
Changes:
- Uses
to_numpy()for target and tensor conversions.
File summaries
| File | Summary |
|---|---|
7-TimeSeries/common/utils.py |
Updated two pandas conversions; lesson-local utility copies remain unchanged. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| inputs = {} | ||
| y = dataframe['target'] | ||
| y = y.as_matrix() | ||
| y = y.to_numpy() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the deprecated DataFrame.as_matrix() API with DataFrame.to_numpy() to restore compatibility with modern pandas versions.