Center dialogs and message boxes on their parent window - #106
Open
Tomas Hansson (tomashan) wants to merge 1 commit into
Open
Center dialogs and message boxes on their parent window#106Tomas Hansson (tomashan) wants to merge 1 commit into
Tomas Hansson (tomashan) wants to merge 1 commit into
Conversation
Dialogs and message boxes were shown without an explicit owner, so FormStartPosition.CenterParent had no parent to center against and placement fell back to inconsistent, sometimes off-monitor behavior (especially for non-modal Form.Show(), which never infers an owner). Passing the parent form explicitly to ShowDialog/Show/MessageBox.Show throughout MainForm, RDPConnect, AssetLibrarySearch, AddNSG, Parameters, and ChooseProject makes every dialog center on and stay stacked above its parent, on the parent's monitor.
Tomas Hansson (tomashan)
force-pushed
the
center-dialogs-on-parent
branch
from
September 11, 2026 09:52
d05068f to
00825b1
Compare
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dialogs and message boxes were shown without an explicit owner, so
FormStartPosition.CenterParenthad no parent to center against and placement fell back to inconsistent, sometimes off-monitor behavior (especially for non-modalForm.Show(), which never infers an owner).This change passes the parent form explicitly to
ShowDialog/Show/MessageBox.ShowthroughoutMainForm,RDPConnect,AssetLibrarySearch,AddNSG,Parameters, andChooseProject, so every dialog centers on and stays stacked above its parent, on the parent's monitor.Test plan
msbuild 2LCS.sln) — succeeds with no warnings/errors