Upgrade hang fixes - #10
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 17e22a8c11
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const timeout = setTimeout(() => { | ||
| console.warn('Legacy recording upgrade timed out.'); | ||
| self.continue_without_legacy_upgrade(); | ||
| }, LEGACY_UPGRADE_TIMEOUT_MILLIS); |
There was a problem hiding this comment.
This single timer covers the entire legacy scan and every sequential clip conversion, but normalize_imported_audio analyzes and transcodes each complete audio file. On a slower device, a long recording, or a library containing several recordings, valid work can exceed 30 seconds; the timeout then marks the upgrade cancelled, discards a late conversion, and did_check_for_legacy prevents another attempt for the lifetime of the process. A clip that consistently takes over 30 seconds can therefore remain inaccessible on every launch even though conversion is making progress, so the timeout should detect inactivity or reset around individual progress rather than cap the whole migration.
Useful? React with 👍 / 👎.
1 participant
We try to convert 1.0 saved recordings to the new format. Sometimes thinks go wrong, and this should make it more robust to at least not hang the app forever.
cc: @vincentritter