feat(setup): migrate to Python_FIND_ABI for CMake's FindPython - #292
Merged
Conversation
XuehaiPan
added
cxx
Only set the automatic Python_FIND_ABI hint with CMake 4.1.2 or newer, while preserving explicit overrides from setup.py. Detect the interpreter ABI in CMake where FindPython handles module-only artifacts correctly.
Add Python 3.14 and 3.15 to the Pyodide build matrix so the FindPython compatibility path is covered by CI.
XuehaiPan
force-pushed
the
fix-cmake-findpython
branch
from
August 17, 2026 13:10
4b14ff0 to
15c46e0
Compare
There was a problem hiding this comment.
Pull request overview
Migrates CMake Python ABI discovery to Python_FIND_ABI, improving debug and free-threaded Python build support.
Changes:
- Detects and forwards Python debug/free-threaded ABI flags.
- Expands Pyodide testing and removes the obsolete Windows CMake pin.
- Updates changelog, spelling dictionary, and pre-commit dependencies.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
CMakeLists.txt |
Configures Python_FIND_ABI for supported CMake versions. |
setup.py |
Logs ABI variables and forwards ABI overrides. |
src/CMakeLists.txt |
Aligns command formatting. |
pyproject.toml |
Adds Pyodide test configuration. |
.github/workflows/build.yml |
Adds Python 3.14–3.15 Pyodide builds. |
.github/workflows/tests-with-pydebug.yml |
Removes the obsolete CMake version pin. |
.pre-commit-config.yaml |
Updates Ruff and mypy hooks. |
docs/source/spelling_wordlist.txt |
Adds ABI-related terminology. |
CHANGELOG.md |
Records the migration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes in detail.
Motivation and Context
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax
close #15213if this solves the issue #15213Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!
make format. (required)make lint. (required)make testpass. (required)