Fix RX Boosted Gain setting after AGC reset is triggered - #3158
Merged
oltaco merged 1 commit intoAug 10, 2026
Conversation
… current/flash value set by the user when the ACG reset is triggered. This commit fixes this.
Author
|
Builds and links for the Station G2: |
Contributor
|
We will test this PR too. |
Member
|
Thanks @mepholic 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AGC reset actually seems to just reset the entire SX1262. When the "AGC reset" function is called, the firmware needs to re-initialize settings on the radio. One of these settings is the RX Boosted Gain.
HerculesMulligan pointed out in the discord that when the AGC reset is triggered, it appears to reset the RX boosted gain value to the compiled in default rather than the setting set by the user. https://discord.com/channels/1495203904898728149/1495410606985969765/1536169618794877018
This seemed like a simple fix after a quick look at the code. I haven't tested this PR at the time of creation, but will work on doing so afterwards. I'll comment on the PR once I've tested it out.